Skip to content

Update go-connections dependency#238

Merged
vdemeester merged 1 commit intodocker:masterfrom
vdemeester:update-go-connections
Jun 29, 2017
Merged

Update go-connections dependency#238
vdemeester merged 1 commit intodocker:masterfrom
vdemeester:update-go-connections

Conversation

@vdemeester
Copy link
Copy Markdown
Collaborator

🐸

Signed-off-by: Vincent Demeester [email protected]

Signed-off-by: Vincent Demeester <[email protected]>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 24, 2017

Codecov Report

Merging #238 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #238      +/-   ##
=========================================
+ Coverage   47.19%   47.2%   +<.01%     
=========================================
  Files         171     171              
  Lines       11556   11556              
=========================================
+ Hits         5454    5455       +1     
+ Misses       5791    5790       -1     
  Partials      311     311

Copy link
Copy Markdown
Contributor

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

ping @cpuguy83 PTAL

Copy link
Copy Markdown
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester merged commit 8de604c into docker:master Jun 29, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jun 29, 2017
@vdemeester vdemeester deleted the update-go-connections branch June 29, 2017 16:04
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Jul 2, 2017
Includes changes from;

- Fix handling of remote "git@" notation (moby/moby#33696)
- Move some `api` package functions away moby/moby#33798 (related to docker#236)
- Update go-connections dependency moby/moby#33814 (already vendored in docker#238)
- Set ping version even on error (moby/moby#33827)
- Do not add duplicate platform information to service spec (moby/moby#33867)
- Refactor MountPoint Setup function in volume.go (moby/moby#33890)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants