vendor: add missing containerd/cgroups dependency#2329
Merged
silvin-lubecki merged 1 commit intodocker:masterfrom Feb 12, 2020
Merged
vendor: add missing containerd/cgroups dependency#2329silvin-lubecki merged 1 commit intodocker:masterfrom
silvin-lubecki merged 1 commit intodocker:masterfrom
Conversation
This dependency is references in the hcsshim package, but was not added when hcsshim was updated in dff269b The missing dependency was printed as a warning by vndr: WARNING: dependency is not vendored: github.com/containerd/cgroups/stats/v1 But somehow didn't get noticed in CI (possibly because our "make cross" builds multiple targets, and a single failure isn't noticed?) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was referenced Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dependency is references in the hcsshim package, but
was not added when hcsshim was updated in dff269b (#2242)
The missing dependency was printed as a warning by vndr:
But somehow didn't get noticed in CI (possibly because our "make cross" builds
multiple targets, and a single failure isn't noticed?)