Skip to content

Fix: docker push --quiet suppressing errors and exit code#2287

Merged
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:fix_quiet_push
Jan 24, 2020
Merged

Fix: docker push --quiet suppressing errors and exit code#2287
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:fix_quiet_push

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

fixes #2284
relates to #2197

Before this patch:

docker push --quiet nosuchimage
docker.io/library/nosuchimage

echo $?
0

With this patch applied:

docker push --quiet nosuchimage:latest
An image does not exist locally with the tag: nosuchimage

echo $?
1

Before this patch:

    docker push --quiet nosuchimage
    docker.io/library/nosuchimage

    echo $?
    0

With this patch applied:

    docker push --quiet nosuchimage:latest
    An image does not exist locally with the tag: nosuchimage

    echo $?
    1

Signed-off-by: Sebastiaan van Stijn <[email protected]>

@silvin-lubecki silvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit e753eec into docker:master Jan 24, 2020
@thaJeztah
thaJeztah deleted the fix_quiet_push branch January 24, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker push --quiet suppresses errors and non-zero exit code

3 participants