Skip to content

docker info: list CLI plugins alphabetically#2236

Merged
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:plugin_sorting
Jan 6, 2020
Merged

docker info: list CLI plugins alphabetically#2236
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:plugin_sorting

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Before this change, plugins were listed in a random order:

Client:
 Debug Mode: false
 Plugins:
  doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
  shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)
  app: Docker Application (Docker Inc., v0.8.0)
  buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)

With this change, plugins are listed alphabetically:

Client:
 Debug Mode: false
 Plugins:
  app: Docker Application (Docker Inc., v0.8.0)
  buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)
  doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
  shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Before this change, plugins were listed in a random order:

    Client:
     Debug Mode: false
     Plugins:
      doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
      shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)
      app: Docker Application (Docker Inc., v0.8.0)
      buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)

With this change, plugins are listed alphabetically:

    Client:
     Debug Mode: false
     Plugins:
      app: Docker Application (Docker Inc., v0.8.0)
      buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)
      doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
      shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@FernandoMiguel

Copy link
Copy Markdown

oh wait, I'm not a contributor to this repo ahah

@thaJeztah

Copy link
Copy Markdown
Member Author

reviewing is open to everyone! more eyes never hurt, right? 👌🤗

@FernandoMiguel

Copy link
Copy Markdown

@thaJeztah for sure.
but i'm a collaborator on buildkit and buildx repo... and the ticket from there linked to this PR....
I reviewed and approved, before realising here won't make much difference on the workflow :)

@thaJeztah

Copy link
Copy Markdown
Member Author

ping @silvin-lubecki @vdemeester PTAL 🤗

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@silvin-lubecki silvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit f7f4a19 into docker:master Jan 6, 2020
@thaJeztah
thaJeztah deleted the plugin_sorting branch January 6, 2020 15:33
@thaJeztah thaJeztah added this to the next milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants