Skip to content

35991 - Modify CLI docs to specify working of device flag#2218

Merged
thaJeztah merged 1 commit intodocker:masterfrom
akhilerm:privileged-device-doc
Jan 9, 2020
Merged

35991 - Modify CLI docs to specify working of device flag#2218
thaJeztah merged 1 commit intodocker:masterfrom
akhilerm:privileged-device-doc

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Dec 8, 2019

Signed-off-by: Akhil Mohan [email protected]

- What I did
Modify the docker run docs, to specify working of --device flag
in containers that are started in privileged mode. The custom device
permissions that are given to a device in privileged mode are ignored
and goes with rwm by default

fixes #35991

- How I did it
The changes are in PR #40291

- Description for the changelog

modify docker run CLI docs to update with the new behaviour of --device flag

- A picture of a cute animal (not mandatory but encouraged)

Modify the docker run docs, to specify working of --device flag
in containers that are started in privileged mode. The custom device
permissions that are given to a device in privileged mode are ignored
and goes with `rwm` by default

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm akhilerm requested a review from thaJeztah as a code owner December 8, 2019 14:35
@thaJeztah thaJeztah changed the title 35991 - Modify CLI docs to specify working of device flag [WIP] 35991 - Modify CLI docs to specify working of device flag Dec 12, 2019
@thaJeztah
Copy link
Copy Markdown
Member

marked as "work in progress" as this depends on moby/moby#40291

@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Jan 3, 2020

@thaJeztah Removing [WIP] tag since the dependent PR is merged. Can you review the docs.

@akhilerm akhilerm changed the title [WIP] 35991 - Modify CLI docs to specify working of device flag 35991 - Modify CLI docs to specify working of device flag Jan 3, 2020
@thaJeztah thaJeztah added this to the next milestone Jan 9, 2020
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 69b5c4c into docker:master Jan 9, 2020
Copy link
Copy Markdown
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilerm akhilerm deleted the privileged-device-doc branch January 13, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--device not work well when start container with --privileged option

4 participants