[19.03] Backport #1857: Support GOARM and windows .exe in binary target#1927
Merged
thaJeztah merged 1 commit intodocker:19.03from Jun 6, 2019
Merged
[19.03] Backport #1857: Support GOARM and windows .exe in binary target#1927thaJeztah merged 1 commit intodocker:19.03from
thaJeztah merged 1 commit intodocker:19.03from
Conversation
This just makes it easier to build a targeted binary for the goos/goach/goarm version. This of course will not work for all cases but is nice to get things going. Specifically cross-compiling pkcs for yubikey support requires some extra work whichis not tackled here. Signed-off-by: Brian Goff <[email protected]> (cherry picked from commit 15130e3) Signed-off-by: Brian Goff <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 19.03 #1927 +/- ##
=======================================
Coverage 56.69% 56.69%
=======================================
Files 310 310
Lines 21778 21778
=======================================
Hits 12346 12346
Misses 8519 8519
Partials 913 913 |
Member
|
all green; I'll get this one in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1857
Figured lets go ahead and get this on the 19.03 tree.
This just makes it easier to build a targeted binary for the
goos/goach/goarm version.
This of course will not work for all cases but is nice to get things
going.
Specifically cross-compiling pkcs for yubikey support requires some
extra work whichis not tackled here.
Signed-off-by: Brian Goff [email protected]
(cherry picked from commit 15130e3)
Signed-off-by: Brian Goff [email protected]