Support GOARM and windows .exe in binary target#1857
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 14, 2019
Merged
Conversation
This just makes it easier to build a targeted binary for the goos/goach/goarm version. This of course will not work for all cases but is nice to get things going. Specifically cross-compiling pkcs for yubikey support requires some extra work whichis not tackled here. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
allow_better_cross_support
branch
from
6883f55 to
15130e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
=======================================
Coverage 56.75% 56.75%
=======================================
Files 309 309
Lines 21658 21658
=======================================
Hits 12292 12292
Misses 8469 8469
Partials 897 897 |
Collaborator
Author
|
Ping |
thaJeztah
approved these changes
May 14, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
ping @tonistiigi @tiborvass PTAL
thaJeztah
added a commit
that referenced
this pull request
Jun 6, 2019
[19.03] Backport #1857: Support GOARM and windows .exe in binary target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just makes it easier to build a targeted binary for the
goos/goach/goarm version.
This of course will not work for all cases but is nice to get things
going.
Specifically cross-compiling pkcs for yubikey support requires some
extra work which is not tackled here.