Skip to content

[18.09 backport] Fix bash completion for service update --force#1526

Merged
silvin-lubecki merged 1 commit intodocker:18.09from
thaJeztah:18.09_backport_completion_fix_service__force
Nov 21, 2018
Merged

[18.09 backport] Fix bash completion for service update --force#1526
silvin-lubecki merged 1 commit intodocker:18.09from
thaJeztah:18.09_backport_completion_fix_service__force

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Nov 20, 2018

backport of #1521 for 18.09

git checkout -b 18.09_backport_completion_fix_service__force upstream/18.09
git cherry-pick -s -S -x 5fa5eb1da6996ea9cb0249d098ebdf3eb1452b46
git push -u origin

cherry-pick was clean; no conflicts

  • --force is not available in service create
  • --force is a boolean option

@albers @thaJeztah
Fix bash completion for service update --force
046ffa4 
- `--force` is not available in `service create`
- `--force` is a boolean option

Signed-off-by: Harald Albers <[email protected]>
(cherry picked from commit 5fa5eb1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 18.09.1 milestone Nov 20, 2018
@thaJeztah thaJeztah requested a review from albers as a code owner November 20, 2018 17:19
vdemeester
vdemeester approved these changes Nov 20, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 20, 2018

Codecov Report

Merging #1526 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #1526   +/-   ##
=======================================
  Coverage   54.07%   54.07%           
=======================================
  Files         290      290           
  Lines       19394    19394           
=======================================
  Hits        10488    10488           
  Misses       8235     8235           
  Partials      671      671

albers
albers approved these changes Nov 20, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

silvin-lubecki
silvin-lubecki approved these changes Nov 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 31c092e into docker:18.09 Nov 21, 2018
@thaJeztah thaJeztah deleted the 18.09_backport_completion_fix_service__force branch November 21, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@albers albers albers approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees

No one assigned

Labels

area/completion status/2-code-review

Projects

None yet

Milestone

18.09.1

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah @codecov-io @vdemeester @albers @silvin-lubecki @GordonTheTurtle