support --mount type=bind,bind-nonrecursive,... by AkihiroSuda · Pull Request #1430 · docker/cli

AkihiroSuda · 2018-10-10T11:58:34Z

Signed-off-by: Akihiro Suda [email protected]

- What I did

Add --mount type=bind,bind-nonrecursive...

- How I did it

By using API v1.40 (unmerged PR: moby/moby#38003)

- How to verify it

$ mountpoint /run
/run is a mountpoint
$ docker run --rm --mount type=bind,src=/,target=/host,readonly busybox touch /host/run/compromise_success
$ docker run --rm --mount type=bind,src=/,target=/host,readonly,bind-nonrecursive busybox touch /host/run/compromise_fail
touch: /host/run/compromise_fail: Read-only file system
$ sudo ls /run/compromise_*
/run/compromise_success

- Description for the changelog

support --mount type=bind,bind-nonrecursive,...

- A picture of a cute animal (not mandatory but encouraged)

https://upload.wikimedia.org/wikipedia/commons/2/28/Kaiserpinguine_mit_Jungen.jpg

codecov-io · 2018-10-10T17:05:53Z

Codecov Report

Merging #1430 into master will decrease coverage by 0.06%.
The diff coverage is 8%.

@@            Coverage Diff             @@
##           master    #1430      +/-   ##
==========================================
- Coverage   55.38%   55.32%   -0.07%     
==========================================
  Files         283      283              
  Lines       19305    19330      +25     
==========================================
+ Hits        10692    10694       +2     
- Misses       7919     7939      +20     
- Partials      694      697       +3

AkihiroSuda · 2018-11-07T07:06:33Z

rebased

AkihiroSuda · 2018-11-07T07:16:51Z

Test failure seems unrelated

--- FAIL: TestActivateBadLicense (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x6985d2]

goroutine 9 [running]:
testing.tRunner.func1(0xc00011c900)
	/usr/local/go/src/testing/testing.go:792 +0x387
panic(0xd55bc0, 0x1610670)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
net/http.(*Client).deadline(0x0, 0xc0000c6080, 0xc000124300, 0xc000034b40)
	/usr/local/go/src/net/http/client.go:187 +0x22
net/http.(*Client).do(0x0, 0xc00011ce00, 0x0, 0x0, 0x0)
	/usr/local/go/src/net/http/client.go:527 +0xab
net/http.(*Client).Do(0x0, 0xc00011ce00, 0x0, 0x0, 0xc000305020)
	/usr/local/go/src/net/http/client.go:509 +0x35
github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).doRequest(0xc000124100, 0xf852c0, 0xc000086010, 0xc00011cd00, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/request.go:132 +0x13b
github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).sendRequest(0xc000124100, 0xf852c0, 0xc000086010, 0xe7089f, 0x3, 0xe71b0e, 0x5, 0xc0000ac5d0, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/request.go:121 +0x153
github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).get(0xc000124100, 0xf852c0, 0xc000086010, 0xe71b0e, 0x5, 0xc0000ac5d0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/request.go:36 +0xe3
github.com/docker/cli/vendor/github.com/docker/docker/client.(*Client).Info(0xc000124100, 0xf852c0, 0xc000086010, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/vendor/github.com/docker/docker/client/info.go:15 +0x144
github.com/docker/cli/cli/command.ElectAuthServer(0xf852c0, 0xc000086010, 0xf90000, 0xc000344640, 0xc0000ad3e8, 0x40bb6f)
	/go/src/github.com/docker/cli/cli/command/registry.go:30 +0xbd
github.com/docker/cli/cli/command.ResolveAuthConfig(0xf852c0, 0xc000086010, 0xf90000, 0xc000344640, 0xc00002e600, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/cli/command/registry.go:75 +0x192
github.com/docker/cli/cli/command/engine.authResolver.func1(0xf852c0, 0xc000086010, 0xc00002e600, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/cli/command/engine/auth.go:32 +0xa1
github.com/docker/cli/cli/trust.GetImageReferencesAndAuth(0xf852c0, 0xc000086010, 0x0, 0x0, 0xc00000ae20, 0xc000308d80, 0x16, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/cli/trust/trust.go:326 +0x140
github.com/docker/cli/cli/command/engine.getRegistryAuth(0xf90000, 0xc000344640, 0xe82bee, 0x16, 0xc000096980, 0x0, 0x0)
	/go/src/github.com/docker/cli/cli/command/engine/auth.go:23 +0x193
github.com/docker/cli/cli/command/engine.runActivate(0xf90000, 0xc000344640, 0xe78d56, 0xb, 0x0, 0x0, 0xe82bee, 0x16, 0x0, 0x0, ...)
	/go/src/github.com/docker/cli/cli/command/engine/activate.go:81 +0x14f
github.com/docker/cli/cli/command/engine.newActivateCommand.func1(0xc0000e0f00, 0xc00000ad60, 0x0, 0x2, 0x0, 0x0)
	/go/src/github.com/docker/cli/cli/command/engine/activate.go:52 +0x7e
github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).execute(0xc0000e0f00, 0xc00002e040, 0x2, 0x2, 0xc0000e0f00, 0xc00002e040)
	/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:762 +0x473
github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc0000e0f00, 0xc00011ca00, 0xc0000e0f00, 0xc00011fb20)
	/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:852 +0x2fd
github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).Execute(0xc0000e0f00, 0xe74d07, 0x7)
	/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:800 +0x2b
github.com/docker/cli/cli/command/engine.TestActivateBadLicense(0xc00011c900)
	/go/src/github.com/docker/cli/cli/command/engine/activate_test.go:47 +0xd6
testing.tRunner(0xc00011c900, 0xeba620)
	/usr/local/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:878 +0x353
FAIL	github.com/docker/cli/cli/command/engine	0.019s
make: *** [Makefile:22: test-coverage] Error 1

https://circleci.com/gh/docker/cli/18777?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

AkihiroSuda · 2018-11-07T07:45:17Z

The CI failure above seems related to moby/moby@3e5b9cb

@cpuguy83 PTAL?

vdemeester · 2018-11-08T09:07:42Z

Should be fixed #1504

vdemeester

LGTM 🐯

AkihiroSuda · 2018-11-08T17:17:12Z

rebased

AkihiroSuda · 2018-11-08T17:21:54Z

Marked the PR as WIP, as this PR lacks doc

AkihiroSuda · 2018-11-09T15:26:19Z

added docs.

@thaJeztah PTAL?

thaJeztah

Thanks for the docs! Found some small issues, but looks good otherwise

opts/mount.go

docs/reference/commandline/service_create.md

AkihiroSuda · 2018-11-19T10:44:06Z

updated

man/docker-run.1.md

docs/reference/commandline/service_create.md

AkihiroSuda · 2018-12-20T08:27:48Z

ping @thaJeztah @cpuguy83

cpuguy83

LGTM

AkihiroSuda · 2018-12-26T05:26:13Z

ping @thaJeztah ^^

vdemeester

LGTM 🐯

AkihiroSuda · 2019-01-08T08:01:18Z

@thaJeztah PTAL?

thaJeztah

Last few docs comments, but LGTM after those are done 😅 (sorry for the delay)

docs/reference/commandline/service_create.md

man/docker-run.1.md

docs/reference/commandline/service_create.md

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda · 2019-01-10T03:08:31Z

updated

thaJeztah

LGTM, thanks!

are follow-up changes needed to support this in the compose file format?

AkihiroSuda · 2019-01-11T03:02:39Z

cc @shin-

GordonTheTurtle added the status/0-triage label Oct 10, 2018

This was referenced Oct 10, 2018

mount: add BindOptions.NonRecursive (API v1.40) moby/moby#38003

Merged

RFC: recursive read-only bind-mount emulation using FUSE moby/moby#37838

Closed

AkihiroSuda changed the title ~~[DNM/dirtyvendor] support --mount type=bind,bind-norecursive,...~~ [moby#38003] support --mount type=bind,bind-norecursive,... Oct 10, 2018

AkihiroSuda force-pushed the non-recursive-bind branch 2 times, most recently from 4eb3d9a to 7faef7a Compare October 10, 2018 17:05

AkihiroSuda force-pushed the non-recursive-bind branch from 7faef7a to 8a3ee2b Compare October 10, 2018 17:12

AkihiroSuda force-pushed the non-recursive-bind branch from 8a3ee2b to 81c938f Compare October 31, 2018 03:59

AkihiroSuda changed the title ~~[moby#38003] support --mount type=bind,bind-norecursive,...~~ [moby#38003] support --mount type=bind,bind-nonrecursive,... Oct 31, 2018

AkihiroSuda force-pushed the non-recursive-bind branch from 81c938f to b2b92af Compare November 7, 2018 07:06

AkihiroSuda changed the title ~~[moby#38003] support --mount type=bind,bind-nonrecursive,...~~ support --mount type=bind,bind-nonrecursive,... Nov 7, 2018

vdemeester approved these changes Nov 8, 2018

View reviewed changes

AkihiroSuda force-pushed the non-recursive-bind branch from b2b92af to 36a2f3e Compare November 8, 2018 17:17

AkihiroSuda changed the title ~~support --mount type=bind,bind-nonrecursive,...~~ [WIP:doc is missing]support --mount type=bind,bind-nonrecursive,... Nov 8, 2018

AkihiroSuda changed the title ~~[WIP:doc is missing]support --mount type=bind,bind-nonrecursive,...~~ support --mount type=bind,bind-nonrecursive,... Nov 9, 2018

AkihiroSuda requested a review from thaJeztah as a code owner November 9, 2018 15:26

AkihiroSuda force-pushed the non-recursive-bind branch from 1df2ac0 to b4b59a4 Compare November 9, 2018 15:27

thaJeztah requested changes Nov 10, 2018

View reviewed changes

opts/mount.go Show resolved Hide resolved

docs/reference/commandline/service_create.md Show resolved Hide resolved

docs/reference/commandline/service_create.md Outdated Show resolved Hide resolved

thaJeztah added impact/changelog status/2-code-review impact/documentation and removed status/0-triage labels Nov 10, 2018

AkihiroSuda force-pushed the non-recursive-bind branch from b4b59a4 to 6a2ad8e Compare November 19, 2018 10:44

cpuguy83 reviewed Nov 19, 2018

View reviewed changes

man/docker-run.1.md Outdated Show resolved Hide resolved

AkihiroSuda force-pushed the non-recursive-bind branch from 6a2ad8e to 899f859 Compare November 22, 2018 05:35

cpuguy83 reviewed Nov 26, 2018

View reviewed changes

docs/reference/commandline/service_create.md Outdated Show resolved Hide resolved

cpuguy83 approved these changes Dec 20, 2018

View reviewed changes

vdemeester approved these changes Dec 26, 2018

View reviewed changes

thaJeztah requested changes Jan 9, 2019

View reviewed changes

AkihiroSuda force-pushed the non-recursive-bind branch from 899f859 to e423deb Compare January 10, 2019 03:05

support --mount type=bind,bind-nonrecursive,...

a7b5f2d

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda force-pushed the non-recursive-bind branch from e423deb to a7b5f2d Compare January 10, 2019 03:07

thaJeztah approved these changes Jan 10, 2019

View reviewed changes

thaJeztah merged commit f5280d6 into docker:master Jan 10, 2019

GordonTheTurtle added this to the 19.03.0 milestone Jan 10, 2019

AkihiroSuda mentioned this pull request Jun 13, 2019

Feature request: port over docker run --mount type=bind,bind-nonrecursive containers/podman#3314

Closed

thaJeztah mentioned this pull request Sep 23, 2019

Subfolders of read-only volume are writeable docker/for-linux#788

Closed

3 tasks

Conversation

AkihiroSuda commented Oct 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Oct 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AkihiroSuda commented Nov 7, 2018

Uh oh!

AkihiroSuda commented Nov 7, 2018

Uh oh!

AkihiroSuda commented Nov 7, 2018

Uh oh!

vdemeester commented Nov 8, 2018

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Nov 8, 2018

Uh oh!

AkihiroSuda commented Nov 8, 2018

Uh oh!

AkihiroSuda commented Nov 9, 2018

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AkihiroSuda commented Nov 19, 2018

Uh oh!

Uh oh!

Uh oh!

AkihiroSuda commented Dec 20, 2018

Uh oh!

cpuguy83 left a comment

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Dec 26, 2018

Uh oh!

vdemeester left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Jan 8, 2019

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AkihiroSuda commented Jan 10, 2019

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Jan 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AkihiroSuda commented Oct 10, 2018 •

edited

Loading

codecov-io commented Oct 10, 2018 •

edited

Loading

vdemeester left a comment •

edited

Loading