Docker build cannot resolve git context with html escapes #2164
Description
Description
Running docker build when the context is a git repository with html escaped characters fails with an error message that seems to be related to the characters becoming unescaped.
Steps to reproduce the issue:
Concretely, for a remote git repository located at git://foo%[email protected]:2222/myrepo.git
docker build -f Dockerfile git://foo%[email protected]:2222/myrepo.git
Describe the results you received:
Gives unable to prepare context: unable to 'git clone' to temporary context directory: error fetching: fatal: unable to look up [email protected]@gitrepos.barcorp.com (port 2222) (Name or service not known)
It seems, based on the error message, that the git url is being (incorrectly) being html unescaped.
Describe the results you expected:
Successfully pulling in the git repo as a context for the Dockerfile
Output of docker version:
Client:
Version: 18.09.1-ol
API version: 1.39
Go version: go1.10.8
Git commit: e32a1bd
Built: Thu Jun 6 14:55:42 2019
OS/Arch: linux/amd64
Experimental: false
Server: Docker Engine - Community
Engine:
Version: 18.09.1-ol
API version: 1.39 (minimum version 1.12)
Go version: go1.10.8
Git commit: e32a1bd
Built: Thu Jun 6 14:47:41 2019
OS/Arch: linux/amd64
Experimental: false
Default Registry: docker.io
Output of docker info:
Containers: 9
Running: 0
Paused: 0
Stopped: 9
Images: 19
Server Version: 18.09.1-ol
Storage Driver: overlay2
Backing Filesystem: xfs
Supports d_type: true
Native Overlay Diff: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version:
runc version: 4bb1fe4ace1a32d3676bb98f5d3b6a4e32bf6c58
init version: fec3683
Security Options:
seccomp
Profile: default
Kernel Version: 4.14.35-1902.4.8.el7uek.x86_64
Operating System: Oracle Linux Server 7.7
OSType: linux
Architecture: x86_64
CPUs: 88
Total Memory: 424.8GiB
Name: jaqen.us.oracle.com
ID: CPCM:K56X:HVRK:JUOQ:DRHM:7DAO:45CX:JID6:D2YQ:ZIFJ:5RZH:SIQI
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
HTTP Proxy: http://www-proxy-ash7.us.oracle.com:80/
HTTPS Proxy: http://www-proxy-ash7.us.oracle.com:80/
No Proxy: localhost,.oraclecorp.com,.us.oracle.com
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
Product License: Community Engine