Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v28.5.0-rc.1
Choose a base ref
...
head repository: docker/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v28.5.0
Choose a head ref
  • 19 commits
  • 24 files changed
  • 4 contributors

Commits on Sep 25, 2025

  1. vendor: github.com/docker/docker v28.5.0-rc.1

    full diff: moby/moby@d21856f...v28.5.0-rc.1
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Sep 25, 2025
    Configuration menu
    Copy the full SHA
    f9d2820 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #6501 from thaJeztah/28.x_bump_docker_28.5

    [28.x] vendor: github.com/docker/docker v28.5.0-rc.1
    thaJeztah authored Sep 25, 2025
    Configuration menu
    Copy the full SHA
    a69c591 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2025

  1. cli/command/image: runPush: minor cleanups and linting issues

    - Remove redundant intermediate variables
    - Explicitly use an early return on error instead of combining with
      other checks.
    - Fix unhandled errors and combine defers
    - Remove outstanding TODO that unlikely will be addressed
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit c36e67d)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Sep 26, 2025
    Configuration menu
    Copy the full SHA
    ec00b85 View commit details
    Browse the repository at this point in the history
  2. trust: print deprecation warning when using hub Notary server

    Docker Hub's Notary service is being retired, and now produces
    failures in most cases. Add a warning when attempting to use
    it, pending full removal of trust;
    https://www.docker.com/blog/retiring-docker-content-trust/
    
    With this PR:
    
        DOCKER_CONTENT_TRUST=1 docker pull -q hello-world
        WARNING: Docker is retiring DCT for Docker Official Images (DOI).
                 For details, refer to https://docs.docker.com/go/dct-deprecation/
    
        could not validate the path to a trusted root: unable to retrieve valid leaf certificates
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 43b03ef)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Sep 26, 2025
    Configuration menu
    Copy the full SHA
    0351ece View commit details
    Browse the repository at this point in the history
  3. cli/command/image: pushTrustedReference: internalize constructing ind…

    …exInfo
    
    All information needed can be deducted from the image reference, which
    is used to create a indexInfo, repoInfo, and to resolve auth-config.
    
    In some situations this may result in resolving the auth-config twice
    after it already was resolved to an encoded auth-config.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 9a6313e)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Sep 26, 2025
    Configuration menu
    Copy the full SHA
    d5c181a View commit details
    Browse the repository at this point in the history
  4. Merge pull request #6509 from thaJeztah/28.x_backport_dct_retiring

    [28.x backport] trust: print deprecation warning when using hub Notary server
    austinvazquez authored Sep 26, 2025
    Configuration menu
    Copy the full SHA
    e5bce5c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #6510 from thaJeztah/28.x_backport_auth

    [28.x backport] cli/command/image: pushTrustedReference: internalize constructing indexInfo
    austinvazquez authored Sep 26, 2025
    Configuration menu
    Copy the full SHA
    394991e View commit details
    Browse the repository at this point in the history
  6. cli/manifest/store: deprecate IsNotFound

    Deprecate the IsNotFound utility in favor of errdefs.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit f3fb772)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Sep 26, 2025
    Configuration menu
    Copy the full SHA
    a4ae5f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2025

  1. cli/config/memorystore: remove unused IsErrValueNotFound

    This utility was added in 9b83d5b, but
    was never used. Remove the utility, and rewrite the error returned to
    implement the errdefs.NotFound interface, so that it can be detected
    using the errdefs.IsNotFound() utility if needed.
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 3c78ac2)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Sep 29, 2025
    Configuration menu
    Copy the full SHA
    a3ffb8a View commit details
    Browse the repository at this point in the history
  2. cli/command: explicitly map AuthConfig fields instead of a direct cast

    Commit [cli@27b2797] forked the AuthConfig type from the API, and changed
    existing code to do a direct cast / convert of the forked type to the API
    type. This can cause issues if the API types diverges, such as the removal
    of the Email field.
    
    This patch explicitly maps each field to the corresponding API type, but
    adds some TODOs, because various code-paths only included a subset of the
    fields, which may be intentional for fields that were meant to be handled
    on the daemon / registry-client only.
    
    We should evaluate these conversions to make sure these fields should
    be sent from the client or not (and possibly even removed from the API
    type).
    
    [cli@27b2797]: 27b2797
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 9f02d96)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Sep 29, 2025
    Configuration menu
    Copy the full SHA
    e491078 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #6514 from thaJeztah/28.x_backport_manifeststore_n…

    …otfound
    
    [28.x backport] cli/manifest/store: deprecate IsNotFound
    austinvazquez authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    645c23b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #6518 from thaJeztah/28.x_backport_memstore_notfou…

    …nderr
    
    [28.x backport] cli/config/memorystore: remove unused IsErrValueNotFound
    austinvazquez authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    5e42f82 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #6519 from thaJeztah/28.x_backport_authconfig_no_d…

    …irect_cast
    
    [28.x backport] cli/command: explicitly map AuthConfig fields instead of a direct cast
    austinvazquez authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    a106161 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2025

  1. cli/command: deprecate ResolveDefaultContext

    The ResolveDefaultContext function was exported in [cli@f820766] to allow
    (unit) testing, but did not document that it was only exported for this
    purpose. The only external use of this function is in buildx, which uses
    it in a unit test that can be implemented without this function.
    
    This patch deprecates the function so that we can remove it.
    
    [cli@f820766]: f820766
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 311a97a)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Oct 1, 2025
    Configuration menu
    Copy the full SHA
    d4b7734 View commit details
    Browse the repository at this point in the history
  2. gha: add macOS 15, remove macOS 13 (deprecated)

    The macOS 13 runners are deprecated and will be removed on December 4th,
    with brownouts in November;
    https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/
    
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    (cherry picked from commit 91d8c0b)
    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Oct 1, 2025
    Configuration menu
    Copy the full SHA
    9d9adf6 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #6529 from thaJeztah/28.x_backport_deprecate_Resol…

    …veDefaultContext
    
    [28.x backport] cli/command: deprecate ResolveDefaultContext
    thaJeztah authored Oct 1, 2025
    Configuration menu
    Copy the full SHA
    d7afcf9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f784471 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2025

  1. Merge pull request #6531 from thaJeztah/28.x_backport_bump_macos

    [28.x backport] gha: add macOS 15, remove macOS 13 (deprecated)
    vvoland authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    9c6a0e0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #6522 from thaJeztah/28.x_bump_moby

    [28.x] vendor: github.com/docker/docker cd048300a487 (v28.5.0-dev)
    vvoland authored Oct 2, 2025
    Configuration menu
    Copy the full SHA
    887030f View commit details
    Browse the repository at this point in the history
Loading