Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 2 commits
- 6 files changed
- 1 contributor
Commits on Dec 13, 2018
-
Fix: proxy-configuration being ignored on docker create
Proxies configured in config.json were only taking effect when using `docker run`, but were being ignored when using `docker create`. Before this change: echo '{"proxies":{"default":{"httpProxy":"httpProxy","httpsProxy":"httpsProxy","noProxy":"noProxy","ftpProxy":"ftpProxy"}}}' > config.json docker inspect --format '{{.Config.Env}}' $(docker --config=./ create busybox) [PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] With this change applied: echo '{"proxies":{"default":{"httpProxy":"httpProxy","httpsProxy":"httpsProxy","noProxy":"noProxy","ftpProxy":"ftpProxy"}}}' > config.json docker inspect --format '{{.Config.Env}}' $(docker --config=./ create busybox) [NO_PROXY=noProxy no_proxy=noProxy FTP_PROXY=ftpProxy ftp_proxy=ftpProxy HTTP_PROXY=httpProxy http_proxy=httpProxy HTTPS_PROXY=httpsProxy https_proxy=httpsProxy PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Reported-by: Silvano Cirujano Cuesta <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Commits on Dec 17, 2018
-
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...refactor_proxy_config