Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2291f61
Choose a base ref
...
head repository: docker/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 48d30b5
Choose a head ref
  • 5 commits
  • 193 files changed
  • 2 contributors

Commits on Jan 28, 2021

  1. context: Ensure import paths are valid 

    Signed-off-by: Chris Crone <[email protected]>
    @chris-crone Tibor Vass
    chris-crone authored and Tibor Vass committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    6f49197 View commit details
    Browse the repository at this point in the history

  2. context: Ensure context name is valid on import 

    Signed-off-by: Chris Crone <[email protected]>
    @chris-crone Tibor Vass
    chris-crone authored and Tibor Vass committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    9ecc69d View commit details
    Browse the repository at this point in the history

  3. context: Add tarball e2e tests 

    Signed-off-by: Chris Crone <[email protected]>
    @chris-crone Tibor Vass
    chris-crone authored and Tibor Vass committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    18f33b3 View commit details
    Browse the repository at this point in the history

  4. vendor docker, docker-credential-helpers and golang/sys for execabs p… 

    …ackage

Signed-off-by: Tibor Vass <[email protected]>
(cherry picked from commit 7bef248)
Signed-off-by: Tibor Vass <[email protected]>
    Tibor Vass
    Tibor Vass committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    5941f41 View commit details
    Browse the repository at this point in the history

  5. Use golang.org/x/sys/execabs 

    On Windows, the os/exec.{Command,CommandContext,LookPath} functions
resolve command names that have neither path separators nor file extension
(e.g., "git") by first looking in the current working directory before
looking in the PATH environment variable.
Go maintainers intended to match cmd.exe's historical behavior.

However, this is pretty much never the intended behavior and as an abundance of precaution
this patch prevents that when executing commands.
Example of commands that docker.exe may execute: `git`, `docker-buildx` (or other cli plugin), `docker-credential-wincred`, `docker`.

Note that this was prompted by the [Go 1.15.7 security fixes](https://blog.golang.org/path-security), but unlike in `go.exe`,
the windows path lookups in docker are not in a code path allowing remote code execution, thus there is no security impact on docker.

Signed-off-by: Tibor Vass <[email protected]>
(cherry picked from commit 8d199d5)
Signed-off-by: Tibor Vass <[email protected]>
    Tibor Vass
    Tibor Vass committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    48d30b5 View commit details
    Browse the repository at this point in the history
Loading