fix: fallthrough for non-blocking channel

Benehiko · Benehiko · commit e1a028ced4c1 · 2024-03-01T13:06:12.000+01:00
Signed-off-by: Alano Terblanche &lt;18033717+Benehiko@users.noreply.github.com&gt;
diff --git a/cmd/docker/docker.go b/cmd/docker/docker.go
@@ -7,7 +7,6 @@ import (
 	"os/signal"
 	"strings"
 	"syscall"
-	"time"
 
 	"github.com/docker/cli/cli"
 	pluginmanager "github.com/docker/cli/cli-plugins/manager"
@@ -255,8 +254,7 @@ func tryPluginRun(dockerCli command.Cli, cmd *cobra.Command, subcommand string,
 						_, _ = fmt.Fprintf(dockerCli.Err(), "failed to signal plugin to close: %v\n", err)
 					}
 				}
-			// timeout here if for some reason the channel is still open and not populated.
-			case <-time.After(1 * time.Millisecond):
+			default:
 				// fallthrough and continue with the loop.
 			}
 			retries++

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ import (`
`7`	`7`	`"os/signal"`
`8`	`8`	`"strings"`
`9`	`9`	`"syscall"`
`10`		`- "time"`
`11`	`10`
`12`	`11`	`"github.com/docker/cli/cli"`
`13`	`12`	`pluginmanager "github.com/docker/cli/cli-plugins/manager"`
`@@ -255,8 +254,7 @@ func tryPluginRun(dockerCli command.Cli, cmd *cobra.Command, subcommand string,`
`255`	`254`	`_, _ = fmt.Fprintf(dockerCli.Err(), "failed to signal plugin to close: %v\n", err)`
`256`	`255`	`}`
`257`	`256`	`}`
`258`		`- // timeout here if for some reason the channel is still open and not populated.`
`259`		`- case <-time.After(1 * time.Millisecond):`
	`257`	`+ default:`
`260`	`258`	`// fallthrough and continue with the loop.`
`261`	`259`	`}`
`262`	`260`	`retries++`