cli/command/volume: suppress err output in tests

thaJeztah · thaJeztah · commit db827d583b42 · 2023-03-21T13:21:20.000+01:00
These tests were deliberately producing errors as part of the test, but
printing those errors could be confusing / make it more difficult to find
actual test-failures.

Before this patch:

    === RUN   TestVolumeCreateErrors
    Error: conflicting options: either specify --name or provide positional arg, not both
    Error: "create" requires at most 1 argument.
    See 'create --help'.

    Usage:  create [OPTIONS] [VOLUME] [flags]

    Create a volume
    Error: error creating volume
    --- PASS: TestVolumeCreateErrors (0.00s)
    PASS

With this patch applied:

    === RUN   TestVolumeCreateErrors
    --- PASS: TestVolumeCreateErrors (0.00s)
    PASS

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/volume/create_test.go b/cli/command/volume/create_test.go
@@ -50,6 +50,7 @@ func TestVolumeCreateErrors(t *testing.T) {
 			cmd.Flags().Set(key, value)
 		}
 		cmd.SetOut(io.Discard)
+		cmd.SetErr(io.Discard)
 		assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
 	}
 }
diff --git a/cli/command/volume/inspect_test.go b/cli/command/volume/inspect_test.go
@@ -62,6 +62,7 @@ func TestVolumeInspectErrors(t *testing.T) {
 			cmd.Flags().Set(key, value)
 		}
 		cmd.SetOut(io.Discard)
+		cmd.SetErr(io.Discard)
 		assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
 	}
 }
diff --git a/cli/command/volume/list_test.go b/cli/command/volume/list_test.go
@@ -43,6 +43,7 @@ func TestVolumeListErrors(t *testing.T) {
 			cmd.Flags().Set(key, value)
 		}
 		cmd.SetOut(io.Discard)
+		cmd.SetErr(io.Discard)
 		assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
 	}
 }
diff --git a/cli/command/volume/prune_test.go b/cli/command/volume/prune_test.go
@@ -49,6 +49,7 @@ func TestVolumePruneErrors(t *testing.T) {
 			cmd.Flags().Set(key, value)
 		}
 		cmd.SetOut(io.Discard)
+		cmd.SetErr(io.Discard)
 		assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
 	}
 }
diff --git a/cli/command/volume/remove_test.go b/cli/command/volume/remove_test.go
@@ -33,6 +33,7 @@ func TestVolumeRemoveErrors(t *testing.T) {
 			}))
 		cmd.SetArgs(tc.args)
 		cmd.SetOut(io.Discard)
+		cmd.SetErr(io.Discard)
 		assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ func TestVolumeCreateErrors(t *testing.T) {`
`50`	`50`	`cmd.Flags().Set(key, value)`
`51`	`51`	`}`
`52`	`52`	`cmd.SetOut(io.Discard)`
	`53`	`+ cmd.SetErr(io.Discard)`
`53`	`54`	`assert.ErrorContains(t, cmd.Execute(), tc.expectedError)`
`54`	`55`	`}`
`55`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ func TestVolumeInspectErrors(t *testing.T) {`
`62`	`62`	`cmd.Flags().Set(key, value)`
`63`	`63`	`}`
`64`	`64`	`cmd.SetOut(io.Discard)`
	`65`	`+ cmd.SetErr(io.Discard)`
`65`	`66`	`assert.ErrorContains(t, cmd.Execute(), tc.expectedError)`
`66`	`67`	`}`
`67`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ func TestVolumeListErrors(t *testing.T) {`
`43`	`43`	`cmd.Flags().Set(key, value)`
`44`	`44`	`}`
`45`	`45`	`cmd.SetOut(io.Discard)`
	`46`	`+ cmd.SetErr(io.Discard)`
`46`	`47`	`assert.ErrorContains(t, cmd.Execute(), tc.expectedError)`
`47`	`48`	`}`
`48`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ func TestVolumePruneErrors(t *testing.T) {`
`49`	`49`	`cmd.Flags().Set(key, value)`
`50`	`50`	`}`
`51`	`51`	`cmd.SetOut(io.Discard)`
	`52`	`+ cmd.SetErr(io.Discard)`
`52`	`53`	`assert.ErrorContains(t, cmd.Execute(), tc.expectedError)`
`53`	`54`	`}`
`54`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ func TestVolumeRemoveErrors(t *testing.T) {`
`33`	`33`	`}))`
`34`	`34`	`cmd.SetArgs(tc.args)`
`35`	`35`	`cmd.SetOut(io.Discard)`
	`36`	`+ cmd.SetErr(io.Discard)`
`36`	`37`	`assert.ErrorContains(t, cmd.Execute(), tc.expectedError)`
`37`	`38`	`}`
`38`	`39`	`}`