Fix bug where incorrect response is returned

adyanth · thaJeztah · commit 20ba591b7f36 · 2022-12-06T08:55:47.000+01:00
When server is unreachable and docker checkpoint (or any command that
needs to check the server type) is run, incorrect error was returned.

When checking if the daemon had the right OS, we compared the OSType
from the clients ServerInfo(). In situations where the client cannot
connect to the daemon, a "stub" Info is used for this, in which we
assume the daemon has experimental enabled, and is running the latest
API version.

However, we cannot fill in the correct OSType, so this field is empty
in this situation.

This patch only compares the OSType if the field is non-empty, otherwise
assumes the platform matches.

before this:

    docker -H unix:///no/such/socket.sock checkpoint create test test
    docker checkpoint create is only supported on a Docker daemon running on linux, but the Docker daemon is running on

with this patch:

    docker -H unix:///no/such/socket.sock checkpoint create test test
    Cannot connect to the Docker daemon at unix:///no/such/socket.sock. Is the docker daemon running?

Co-authored-by: Adyanth Hosavalike &lt;ahosavalike@ucsd.edu&gt;
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cmd/docker/docker.go b/cmd/docker/docker.go
@@ -306,7 +306,7 @@ func hideSubcommandIf(subcmd *cobra.Command, condition func(string) bool, annota
 func hideUnsupportedFeatures(cmd *cobra.Command, details versionDetails) error {
 	var (
 		notExperimental = func(_ string) bool { return !details.ServerInfo().HasExperimental }
-		notOSType       = func(v string) bool { return v != details.ServerInfo().OSType }
+		notOSType       = func(v string) bool { return details.ServerInfo().OSType != "" && v != details.ServerInfo().OSType }
 		notSwarmStatus  = func(v string) bool {
 			s := details.ServerInfo().SwarmStatus
 			if s == nil {
@@ -419,10 +419,11 @@ func areSubcommandsSupported(cmd *cobra.Command, details versionDetails) error {
 		if cmdVersion, ok := curr.Annotations["version"]; ok && versions.LessThan(details.CurrentVersion(), cmdVersion) {
 			return fmt.Errorf("%s requires API version %s, but the Docker daemon API version is %s", cmd.CommandPath(), cmdVersion, details.CurrentVersion())
 		}
-		if ost, ok := curr.Annotations["ostype"]; ok && ost != details.ServerInfo().OSType {
-			return fmt.Errorf("%s is only supported on a Docker daemon running on %s, but the Docker daemon is running on %s", cmd.CommandPath(), ost, details.ServerInfo().OSType)
+		si := details.ServerInfo()
+		if ost, ok := curr.Annotations["ostype"]; ok && si.OSType != "" && ost != si.OSType {
+			return fmt.Errorf("%s is only supported on a Docker daemon running on %s, but the Docker daemon is running on %s", cmd.CommandPath(), ost, si.OSType)
 		}
-		if _, ok := curr.Annotations["experimental"]; ok && !details.ServerInfo().HasExperimental {
+		if _, ok := curr.Annotations["experimental"]; ok && !si.HasExperimental {
 			return fmt.Errorf("%s is only supported on a Docker daemon with experimental features enabled", cmd.CommandPath())
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ func hideSubcommandIf(subcmd *cobra.Command, condition func(string) bool, annota`
`306`	`306`	`func hideUnsupportedFeatures(cmd *cobra.Command, details versionDetails) error {`
`307`	`307`	`var (`
`308`	`308`	`notExperimental = func(_ string) bool { return !details.ServerInfo().HasExperimental }`
`309`		`- notOSType = func(v string) bool { return v != details.ServerInfo().OSType }`
	`309`	`+ notOSType = func(v string) bool { return details.ServerInfo().OSType != "" && v != details.ServerInfo().OSType }`
`310`	`310`	`notSwarmStatus = func(v string) bool {`
`311`	`311`	`s := details.ServerInfo().SwarmStatus`
`312`	`312`	`if s == nil {`
`@@ -419,10 +419,11 @@ func areSubcommandsSupported(cmd *cobra.Command, details versionDetails) error {`
`419`	`419`	`if cmdVersion, ok := curr.Annotations["version"]; ok && versions.LessThan(details.CurrentVersion(), cmdVersion) {`
`420`	`420`	`return fmt.Errorf("%s requires API version %s, but the Docker daemon API version is %s", cmd.CommandPath(), cmdVersion, details.CurrentVersion())`
`421`	`421`	`}`
`422`		`- if ost, ok := curr.Annotations["ostype"]; ok && ost != details.ServerInfo().OSType {`
`423`		`- return fmt.Errorf("%s is only supported on a Docker daemon running on %s, but the Docker daemon is running on %s", cmd.CommandPath(), ost, details.ServerInfo().OSType)`
	`422`	`+ si := details.ServerInfo()`
	`423`	`+ if ost, ok := curr.Annotations["ostype"]; ok && si.OSType != "" && ost != si.OSType {`
	`424`	`+ return fmt.Errorf("%s is only supported on a Docker daemon running on %s, but the Docker daemon is running on %s", cmd.CommandPath(), ost, si.OSType)`
`424`	`425`	`}`
`425`		`- if _, ok := curr.Annotations["experimental"]; ok && !details.ServerInfo().HasExperimental {`
	`426`	`+ if _, ok := curr.Annotations["experimental"]; ok && !si.HasExperimental {`
`426`	`427`	`return fmt.Errorf("%s is only supported on a Docker daemon with experimental features enabled", cmd.CommandPath())`
`427`	`428`	`}`
`428`	`429`	`}`