license: add Apache 2.0 headers and NOTICE file for open sourcing#240
Conversation
- Replace LICENSE file with verbatim Apache 2.0 text from apache.org (removes the appended copyright notice that was at line 179) - Add NOTICE file per Apache 2.0 guidelines - Add Apache 2.0 copyright header to all TypeScript source files in src/ - Add Apache 2.0 copyright header to all YAML action files - Add Apache 2.0 copyright header to all GitHub workflow YAML files - Add Apache 2.0 copyright header to all shell scripts in scripts/ and tests/ No generated files (dist/) or non-source files were modified.
Using the NOTICE file approach per Apache 2.0 guidelines instead of adding per-file headers to every source file. Also restores execute bit on scripts/act-local.sh, tests/test-job-summary.sh, and tests/test-output-extraction.sh which was accidentally dropped.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Add short-form SPDX copyright headers to every source file: - TypeScript files in src/: // comment style - YAML action and workflow files: # comment style - Shell scripts: # comment style, after shebang line Header format: // Copyright (c) Docker, Inc. // SPDX-License-Identifier: Apache-2.0 dist/, JSON, markdown, and other non-source files are unchanged.
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
overall LGTM
left a comment; probably may need a double check on the copyright holder; also to have the headers and notice match
| @@ -1,4 +1,8 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Copyright (c) Docker, Inc. | |||
There was a problem hiding this comment.
Probably worth checking what this should be; "Docker, Inc." or "The Docker Agent Action Authors" (or both)
- Remove the APPENDIX section (lines 178-202) from LICENSE. The APPENDIX is guidance text showing how to apply the license to your own works; it is not part of the Apache 2.0 license grant itself, and leaving the unfilled '[yyyy] [name of copyright owner]' placeholder confuses OSS compliance tooling. LICENSE now ends at 'END OF TERMS AND CONDITIONS'. - Update NOTICE copyright line to 'Copyright (c) Docker, Inc.' to align with the SPDX headers added to source files.
|
Addressed the review feedback in f4ae445: LICENSE APPENDIX (docker-agent's HIGH finding): Removed the entire APPENDIX section — LICENSE now ends at "END OF TERMS AND CONDITIONS". The APPENDIX is guidance text showing how to apply the license to your own works, not part of the license grant itself. Stripping it eliminates the unfilled Textual deviations (docker-agent's MEDIUM finding): thaJeztah confirmed these lines match the canonical apache.org text — "the" is not in the upstream file. No change needed there. Copyright holder alignment (thaJeztah's comment): Updated NOTICE from |
The previous commit restored the full verbatim Apache 2.0 text including the APPENDIX, but that contradicts the PR's stated goal: the unfilled '[yyyy] [name of copyright owner]' placeholder confuses OSS compliance tooling. LICENSE now ends at 'END OF TERMS AND CONDITIONS' as described.
4 participants
Prepares the repo for open sourcing by fixing Apache 2.0 licensing artifacts.
Changes
Copyright (c) Docker, Inc.attribution per Apache 2.0 guidelines.src/, 6 YAML action files, 9 workflow YAMLs, 3 shell scripts):#-style comments used for YAML and shell files; shebang lines preserved first.scripts/act-local.sh,tests/test-job-summary.sh,tests/test-output-extraction.sh.dist/, JSON, markdown, and other non-source files are unchanged.