Skip to content

add the data team's PII check to the pr reviewer#145

Merged
derekmisler merged 1 commit into
docker:mainfrom
derekmisler:add-the-data-teams-pii-check-to-the-pr-reviewer
Apr 23, 2026
Merged

add the data team's PII check to the pr reviewer#145
derekmisler merged 1 commit into
docker:mainfrom
derekmisler:add-the-data-teams-pii-check-to-the-pr-reviewer

Conversation

@derekmisler

@derekmisler derekmisler commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Closes: https://github.com/docker/gordon/issues/423

Summary

This PR integrates the data team's PII detection guide (Marlin v2 producer code review) into the PR review agent. It updates the workflow to copy all reference documentation files and makes them available to the review agent, enabling domain-specific guidance for Marlin SDK integration and PII risk detection.

Key Changes

  • Reference file handling (review-pr/action.yml): Changed from copying a single posting format file to copying all reference files (.md) from agents/refs/ into /tmp/refs/, making them accessible to the review agent.

  • Review agent configuration (review-pr/agents/pr-review.yaml): Added documentation for domain-specific review guides. The agent now checks /tmp/refs/ for additional review guidance files (Marlin PII detection guide, posting format, etc.) after analyzing the diff.

  • Evaluation tests (new files):

    • marlin-false-positive-1.json: Validates that the agent correctly skips Marlin guidance for non-Marlin PRs (e.g., generic analytics using Segment).
    • marlin-pii-detection-1.json: Validates that the agent detects Marlin SDK imports and identifies PII risks (unvalidated error messages, command arguments) in analytics event payloads.
✓ Marlin SDK web event from Node server with raw integer enum and non-UUID account_id (run 1) ($0.166632)
  ✓ relevance 6/6
✓ Marlin SDK PageView fired in React render body with wrong timestamp format (run 1) ($0.164642)
  ✓ relevance 5/5
✓ Marlin SDK WebClick with action and elementTag from user input — string_kind and action discriminator violations (run 1) ($0.162822)
  ✓ relevance 5/5
✓ Non-Marlin analytics library — should not trigger Marlin guide (run 1) ($0.114113)
  ✓ relevance 7/7
✓ Marlin SDK Go producer setting ingestor-owned fields, identity mismatch, and UGC truncation (run 1) ($0.183323)
  ✓ relevance 6/6
✓ Marlin SDK AppInvoke analytics with PII risk — err.Error() and command args (run 1) ($0.646032)
  ✓ relevance 9/9
[██████████] 100% (6/6) ✓6 ✗0

✅      Relevance: 38/38 passed (100.0%)

Tip

Comment /review to trigger the PR Reviewer agent for automated feedback.
Comment /describe to generate a PR description.

@derekmisler derekmisler self-assigned this Apr 21, 2026
@derekmisler
derekmisler requested a review from a team April 21, 2026 19:45
@derekmisler
derekmisler marked this pull request as ready for review April 21, 2026 19:45
docker-agent[bot]

This comment was marked as resolved.

@derekmisler
derekmisler force-pushed the add-the-data-teams-pii-check-to-the-pr-reviewer branch from 9f89db2 to 51057d7 Compare April 22, 2026 17:55
@derekmisler
derekmisler force-pushed the add-the-data-teams-pii-check-to-the-pr-reviewer branch from 51057d7 to 3eb67bb Compare April 22, 2026 18:36
@derekmisler

Copy link
Copy Markdown
Contributor Author

waiting for #143

@derekmisler
derekmisler merged commit adf8daf into docker:main Apr 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants