add the data team's PII check to the pr reviewer#145
Merged
derekmisler merged 1 commit intoApr 23, 2026
Merged
Conversation
derekmisler
force-pushed
the
add-the-data-teams-pii-check-to-the-pr-reviewer
branch
from
April 22, 2026 17:55
9f89db2 to
51057d7
Compare
Signed-off-by: Derek Misler <[email protected]>
derekmisler
force-pushed
the
add-the-data-teams-pii-check-to-the-pr-reviewer
branch
from
April 22, 2026 18:36
51057d7 to
3eb67bb
Compare
Contributor
Author
|
waiting for #143 |
trungutt
approved these changes
Apr 22, 2026
gtardif
approved these changes
Apr 23, 2026
krissetto
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/423
Summary
This PR integrates the data team's PII detection guide (Marlin v2 producer code review) into the PR review agent. It updates the workflow to copy all reference documentation files and makes them available to the review agent, enabling domain-specific guidance for Marlin SDK integration and PII risk detection.
Key Changes
Reference file handling (
review-pr/action.yml): Changed from copying a single posting format file to copying all reference files (.md) fromagents/refs/into/tmp/refs/, making them accessible to the review agent.Review agent configuration (
review-pr/agents/pr-review.yaml): Added documentation for domain-specific review guides. The agent now checks/tmp/refs/for additional review guidance files (Marlin PII detection guide, posting format, etc.) after analyzing the diff.Evaluation tests (new files):
marlin-false-positive-1.json: Validates that the agent correctly skips Marlin guidance for non-Marlin PRs (e.g., generic analytics using Segment).marlin-pii-detection-1.json: Validates that the agent detects Marlin SDK imports and identifies PII risks (unvalidated error messages, command arguments) in analytics event payloads.Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.