feat: adding instructions to review producer code for Marlin 2.0#143
Conversation
|
/review |
|
⏭️ Review skipped — another review for this PR is already in progress (started 30s ago). Only one review runs at a time to avoid duplicate comments. The in-progress review will post its results when complete. |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
This PR adds a new Marlin SDK producer code review guide. 7 issues found in the added content — 1 high-severity self-contradiction that renders multiple blocking FAIL checks unenforceable, and 6 medium-severity logic/consistency issues.
|
/review |
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
⚠️ Note: The verifier agent exhausted its context budget and returned no verdicts. The findings below are from the drafter's static analysis of the diff and have not been independently verified. They are surfaced here for the author's evaluation.
This PR adds a Marlin SDK producer review guide with 11 checklist sections. Static analysis identified 2 HIGH and 3 MEDIUM issues in the added content that could cause the AI review agent to produce contradictory, incomplete, or incorrect review output. See inline comments for details.
2 participants
Summary
Adds a reference guide (
review-pr/agents/refs/marlin_v2_producer_code_review.md) that instructs the AI PR review agent how to analyze pull requests in Marlin SDK producer repositories — code that imports the generated Marlin SDK and callstrack()to emit analytics events.What's in the guide
The agent will now detect Marlin SDK usage (Go, TypeScript, Python) and run an 11-point checklist covering: PII field sourcing, string kind correctness, required fields, enum usage, platform context alignment, UGC handling, flow event action discriminators, timestamps, identity graph correctness, event firing patterns, and companion doc alignment.
Each finding is classified as FAIL (blocking) or WARN (advisory), and the agent produces a structured Marlin SDK analysis block as a top-level review comment with severity levels (High / Medium / Low).
Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.