fix timeout/failure to reply to feedback#139
Merged
Merged
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
derekmisler
force-pushed
the
better-verification
branch
from
April 19, 2026 18:36
d2cc86c to
ff334ab
Compare
derekmisler
changed the title
derekmisler
force-pushed
the
better-verification
branch
from
April 20, 2026 15:42
ff334ab to
8ac2d7a
Compare
derekmisler
marked this pull request as draft
April 20, 2026 15:42
derekmisler
force-pushed
the
better-verification
branch
2 times, most recently
from
April 20, 2026 16:31
7c5a29b to
611a982
Compare
Contributor
Author
|
/review |
derekmisler
force-pushed
the
better-verification
branch
from
April 20, 2026 17:54
2829688 to
38c9bf2
Compare
derekmisler
marked this pull request as ready for review
April 20, 2026 17:54
derekmisler
force-pushed
the
better-verification
branch
5 times, most recently
from
April 20, 2026 18:59
b41907a to
9e9f107
Compare
derekmisler
changed the title
derekmisler
force-pushed
the
better-verification
branch
from
April 20, 2026 19:40
9e9f107 to
41d6601
Compare
derekmisler
enabled auto-merge (squash)
April 20, 2026 19:44
Signed-off-by: Derek Misler <[email protected]>
derekmisler
force-pushed
the
better-verification
branch
from
April 20, 2026 19:45
41d6601 to
365dd9c
Compare
derekmisler
commented
Apr 20, 2026
Contributor
Author
There was a problem hiding this comment.
"the amount of bash in there is starting to scare me"
it's true, i hate it. once i get this fixed, i'll continue migrating to TS
dgageot
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/405
What this does
Turns out, the
pull_request_review_commentfalls into the same trap as apull_requestevent on a forked PR. This PR makes the workflow work for both same-repo and fork PRs with a single architecture.Workflow consolidation
Merged the 4 separate jobs (
auto-review,manual-review,capture-feedback,reply-to-feedback) into 3:resolve-context— downloads event context from a trigger workflow artifact (for fork PRs viaworkflow_run)review— unified auto + manual review with source-based routingreply-to-feedback— replies to comments and captures feedback for the learning systemBoth same-repo PRs (direct events) and fork PRs (trigger →
workflow_run→ artifact) go through the same jobs. No fork-specific branching.How consuming repos set up
Same-repo only — 1 workflow, triggers directly on
pull_request/issue_comment/pull_request_review_comment.Supports forks — 2 workflows: a lightweight trigger (saves event context as artifact, no secrets needed) + a main workflow that triggers on
issue_comment+workflow_run.See
review-pr/README.mdfor both setups.Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.