Skip to content

build: return imageID when loading without docker driver#980

Merged
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:imageid
Mar 4, 2022
Merged

build: return imageID when loading without docker driver#980
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:imageid

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Mar 1, 2022 •
edited
Loading

@crazy-max crazy-max requested a review from tonistiigi March 1, 2022 11:43
@crazy-max crazy-max mentioned this pull request Mar 1, 2022
Closed
tonistiigi
tonistiigi reviewed Mar 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just use containerimage.config.digest always and if it is not set (eg. multi-platform) then the full digest as before.

No need to do anything special for --load as multi-platform don't load anyway.

Also need to make sure this doesn't break the github action and update if it may.

@tonistiigi tonistiigi added this to the v0.8.0 milestone Mar 4, 2022
@crazy-max crazy-max requested a review from tonistiigi March 4, 2022 14:32
@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Mar 4, 2022

Also need to make sure this doesn't break the github action and update if it may.

It's fine for the GitHub Action with this behavior but as discussed we might create a new output named imageid that will contain the actual imageid and set digest output accordingly.

@tonistiigi
Copy link
Copy Markdown
Member

tonistiigi commented Mar 4, 2022

It's fine for the GitHub Action with this behavior but as discussed we might create a new output named imageid that will contain the actual imageid and set digest output accordingly.

But what field does the action use atm? If it uses iidfile then it needs to be updated before the release.

@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Mar 4, 2022

Hum yeah atm digest output returns content of iidfile, so need to make changes for the action. Will do that.

@tonistiigi tonistiigi merged commit 8079bd2 into docker:master Mar 4, 2022
@crazy-max crazy-max mentioned this pull request Mar 6, 2022
Merged
@crazy-max crazy-max deleted the imageid branch March 7, 2022 13:21
@crazy-max crazy-max mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.8.0

Development

Successfully merging this pull request may close these issues.

--iidfile contains mismatching id

2 participants

@crazy-max @tonistiigi