bake: add named contexts keys#928
Merged
tonistiigi merged 4 commits intodocker:masterfrom Feb 7, 2022
Merged
Conversation
crazy-max
reviewed
Jan 26, 2022
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Build context “target:<name>” will take the contents from another bake target. Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
bake-named-contexts
branch
from
f95f5c6 to
c3dab80
Compare
crazy-max
approved these changes
Jan 29, 2022
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Ok I played with your PR yesterday and I must say that's a nice way to handle target dependencies. Will be really useful.
Docs is fine too, thanks for this. Also our reference docs like the bake page starts to be huge. I will create a follow-up to see how we could improve that. We might need something like a cookbook to showcase real-world examples. Will see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #926
Enable using named contexts in bake targets. The naming is consistent with build args, and
--build-contextand--build-argare similar and both take key-value pairts.Still working on creating contexts from other targets that is a bit complex. That can be a follow-up PR.Added to same PR. Targets can be linked withtarget:prefix.Signed-off-by: Tonis Tiigi [email protected]