bake: fix groups print#881
Merged
tonistiigi merged 1 commit intodocker:masterfrom Dec 14, 2021
Merged
Conversation
Member
|
Group taking precedence over target sgtm. But should probably also work. |
92eadd6 to
0a18c2b
Compare
Member
Author
It doesn't unfortunately: group "foo" {
targets = ["foo"]
}
target "foo" {
dockerfile = "bar"
}docker buildx bake foo --print
{
"group": {
"default": {
"targets": [
"foo"
]
}
},
"target": {}
}Because group is already visited: Line 91 in 202e996 Changes in |
Member
@crazy-max we can fix that one separately |
Signed-off-by: CrazyMax <[email protected]>
0a18c2b to
4466a24
Compare
tonistiigi
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #877
@tonistiigi Also found an odd case when a group and target can have the same name without erroring:
Not sure if it's expected?
Signed-off-by: CrazyMax [email protected]