imagetools: fix pushing same image with multiple names#815
imagetools: fix pushing same image with multiple names#815tonistiigi merged 1 commit intodocker:masterfrom
Conversation
containerd pusher can’t handle this case atm so we need to make sure we always create a new resolver for each name. Signed-off-by: Tonis Tiigi <[email protected]>
|
tried using these commands: it didn't seem to work how do i us your changes? i think i'm doing something wrong |
|
@eliorm32 You don't seem to show any error you get. Note that this fix is in buildx tool itself that would need to be updated for testing. Nothing to do with |
|
yes i understand now. this fix was suppose to upload two tags to a docker registry for same build when built on different nodes. i opened the issue. i thought i need to load the driver and it would work now i understand that i need the buildx binaries that include the merge. |
|
@eliorm32 If you want to test this you can install buildx from the source. https://github.com/docker/buildx#building |
|
Cool will try tomorrow 🙂 |
3 participants
fixes #799
containerd pusher can’t handle this case atm so we
need to make sure we always create a new resolver
for each name.
This only affects multi-node builds as pushes inside BuildKit use their own resolver pool that protects against this.
Signed-off-by: Tonis Tiigi [email protected]