bake: print default group#720
Merged
tonistiigi merged 1 commit intodocker:masterfrom Aug 12, 2021
Merged
Conversation
crazy-max
force-pushed
the
default-group
branch
from
884dead to
a61072f
Compare
Member
|
I think the point of this should be that the resulting json is usable as a bake file. That means that for |
crazy-max
force-pushed
the
default-group
branch
from
a61072f to
218c454
Compare
Member
Author
Ok, I changed the behavior to also print the default group if targets are specified.
I think it's ok even if combined but yes opt-out sgtm. // docker-bake.hcl
group "default" {
targets = ["image"]
}
target "image" {
inherits = ["image"]
output = ["type=docker"]
}# docker-compose.yaml
services:
addon:
build:
context: .
dockerfile: ./Dockerfile
args:
CT_ECR: foo
CT_TAG: bar
image: ct-addon:bar
environment:
- NODE_ENV=test
- AWS_ACCESS_KEY_ID=dummy
- AWS_SECRET_ACCESS_KEY=dummy
aws:
build:
dockerfile: ./aws.Dockerfile
args:
CT_ECR: foo
CT_TAG: bar
image: ct-fake-aws:bar$ docker buildx bake -f docker-compose.yml -f docker-bake.hcl --print
{
"group": {
"default": [
"image"
]
},
"target": {
"image": {
"context": ".",
"dockerfile": "Dockerfile",
"output": [
"type=docker"
]
}
}
}$ docker buildx bake -f docker-compose.yml -f docker-bake.hcl addon --print
{
"group": {
"default": [
"addon"
]
},
"target": {
"addon": {
"context": ".",
"dockerfile": "./Dockerfile",
"args": {
"CT_ECR": "foo",
"CT_TAG": "bar"
},
"tags": [
"ct-addon:bar"
]
}
}
}$ docker buildx bake -f docker-compose.yml -f docker-bake.hcl addon aws --print
{
"group": {
"default": [
"addon",
"aws"
]
},
"target": {
"addon": {
"context": ".",
"dockerfile": "./Dockerfile",
"args": {
"CT_ECR": "foo",
"CT_TAG": "bar"
},
"tags": [
"ct-addon:bar"
]
},
"aws": {
"context": ".",
"dockerfile": "./aws.Dockerfile",
"args": {
"CT_ECR": "foo",
"CT_TAG": "bar"
},
"tags": [
"ct-fake-aws:bar"
]
}
}
}$ docker buildx bake -f docker-compose.yml -f docker-bake.hcl addon aws image --print
{
"group": {
"default": [
"addon",
"aws",
"image"
]
},
"target": {
"addon": {
"context": ".",
"dockerfile": "./Dockerfile",
"args": {
"CT_ECR": "foo",
"CT_TAG": "bar"
},
"tags": [
"ct-addon:bar"
]
},
"aws": {
"context": ".",
"dockerfile": "./aws.Dockerfile",
"args": {
"CT_ECR": "foo",
"CT_TAG": "bar"
},
"tags": [
"ct-fake-aws:bar"
]
},
"image": {
"context": ".",
"dockerfile": "Dockerfile",
"output": [
"type=docker"
]
}
}
} |
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
default-group
branch
from
218c454 to
c685e46
Compare
crazy-max
changed the title
tonistiigi
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
Signed-off-by: CrazyMax [email protected]