Skip to content

Allow booting builder after creation#692

Merged
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:boostrap-cmd
Aug 12, 2021
Merged

Allow booting builder after creation#692
tonistiigi merged 1 commit intodocker:masterfrom
crazy-max:boostrap-cmd

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Jul 25, 2021

Fixes #189

Allow booting builder after creation with docker buildx create --bootstrap ....

Also adds buildx start command.

Signed-off-by: CrazyMax [email protected]

@crazy-max crazy-max marked this pull request as ready for review July 26, 2021 11:21
@crazy-max crazy-max added the kind/enhancement New feature or request label Aug 2, 2021
@crazy-max crazy-max requested a review from tonistiigi August 8, 2021 09:21
@tonistiigi
Copy link
Copy Markdown
Member

Not sure if we need a command for this. And as we have buildx stop it should probably be start then. But I think we can start with just a flag.

@crazy-max
Copy link
Copy Markdown
Member Author

@tonistiigi

And as we have buildx stop it should probably be start then.

👍

But I think we can start with just a flag.

Yeah I thought bootstrap start was a legit command to have here cause of the stop one. Let me know if you don't think so.

@crazy-max
Copy link
Copy Markdown
Member Author

Remove start command as discussed. PTAL @tonistiigi

@tonistiigi tonistiigi merged commit 04bac63 into docker:master Aug 12, 2021
@crazy-max crazy-max deleted the boostrap-cmd branch August 12, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add --bootstrap to --create

2 participants