fixes #427: Handle empty strings in elements enabling conditional logic#428
Merged
tonistiigi merged 3 commits intodocker:masterfrom Dec 8, 2020
Merged
fixes #427: Handle empty strings in elements enabling conditional logic#428tonistiigi merged 3 commits intodocker:masterfrom
tonistiigi merged 3 commits intodocker:masterfrom
Conversation
Signed-off-by: Anthony Poschen <[email protected]>
Signed-off-by: Anthony Poschen <[email protected]>
Contributor
Author
|
Hi @tonistiigi i would really like to get this into the next release if possible, if anything needs to be changed or modified please let me know. |
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change aims to resolve #427 by allowing either the compact function to be used and also allowing empty strings to be present in the resulting bake file and stripping them out of the final file before actioning.
example file 1 with compact.
Example 2 with allowing empty strings in arrays will no longer cause any issues with docker push as they are stripped.
the above two config files results in the below print