build: don't generate local state for subrequests#2754
Merged
Conversation
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
call-localstate
branch
from
8bb0c1b to
886ae21
Compare
tonistiigi
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/docker/docs/actions/runs/11502549192/job/32017891983#step:6:21
When generating build summary in our GitHub Actions, we are using the
buildx.build.reffrom metadata to export the build record. When usingcall, this attribute is not set:buildx/build/build.go
Lines 525 to 526 in 746eadd
Which is the right behavior as no build record is written for subrequests anyway.
But we also have a fallback in our GitHub Actions in case
buildx.build.refis not set that checks if a local state is available as part of this build. And in this case we have one as we are generating a local state for subrequests but I don't think it makes sense to do so.cc @dvdksn