Skip to content

ls: ensure deterministic output for truncated platforms#2717

Merged
tonistiigi merged 1 commit into
docker:masterfrom
crazy-max:fix-ls-notrunc
Oct 4, 2024
Merged

ls: ensure deterministic output for truncated platforms#2717
tonistiigi merged 1 commit into
docker:masterfrom
crazy-max:fix-ls-notrunc

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Oct 4, 2024

relates to https://github.com/docker/buildx/actions/runs/11169979364/job/31051857680#step:6:1094

=== FAIL: commands TestTruncPlatforms/all_preferred (0.00s)
    ls_test.go:171: 
        	Error Trace:	/home/runner/work/buildx/buildx/commands/ls_test.go:171
        	Error:      	Not equal: 
        	            	expected: "linux/arm64*, linux/arm* (+3), darwin/arm64*, windows/arm64*"
        	            	actual  : "linux/arm64*, linux/arm* (+3), windows/arm64*, darwin/arm64*"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-linux/arm64*, linux/arm* (+3), darwin/arm64*, windows/arm64*
        	            	+linux/arm64*, linux/arm* (+3), windows/arm64*, darwin/arm64*
        	Test:       	TestTruncPlatforms/all_preferred
    --- FAIL: TestTruncPlatforms/all_preferred (0.00s)

=== FAIL: commands TestTruncPlatforms (0.00s)

@crazy-max crazy-max requested a review from tonistiigi October 4, 2024 07:28
@tonistiigi tonistiigi merged commit d353f5f into docker:master Oct 4, 2024
@crazy-max crazy-max deleted the fix-ls-notrunc branch October 4, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

No one assigned

Labels

area/cli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crazy-max @tonistiigi