build: print out the number of warnings after completing a rule check#2647
Merged
tonistiigi merged 1 commit intodocker:masterfrom Sep 3, 2024
Merged
build: print out the number of warnings after completing a rule check#2647tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi merged 1 commit intodocker:masterfrom
Conversation
daghack
force-pushed
the
print-warning-count
branch
from
a3d5c90 to
d9d78e5
Compare
crazy-max
reviewed
Aug 12, 2024
daghack
force-pushed
the
print-warning-count
branch
from
d9d78e5 to
182a898
Compare
crazy-max
reviewed
Aug 13, 2024
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Can we have an integration test for both running check with and without warning to validate this?
daghack
force-pushed
the
print-warning-count
branch
from
182a898 to
e62143c
Compare
Contributor
Author
Added! |
Contributor
Author
|
@crazy-max @tonistiigi ping |
tonistiigi
reviewed
Aug 19, 2024
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
@daghack Did you check the output of this for buildx bake as well?
Contributor
Author
|
@tonistiigi Good catch. Will update! |
Member
Yes another integration for bake would be ideal to make sure |
daghack
force-pushed
the
print-warning-count
branch
2 times, most recently
from
2f99242 to
eb4e3db
Compare
Contributor
Author
|
@crazy-max @tonistiigi Added matching integration checks for bake! :) |
tonistiigi
reviewed
Aug 22, 2024
Signed-off-by: Talon Bowler <[email protected]>
daghack
force-pushed
the
print-warning-count
branch
from
eb4e3db to
806ccd3
Compare
crazy-max
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atm when building with
--check, when there are no warnings we generate the outputCheck completed, no warnings found.When there are warnings, we leap right into displaying them.
This updates the output in the later case to contain a similar "Check completed" message which lists the warning count.