Skip to content

Improvements based on inittrace#2601

Merged
tonistiigi merged 4 commits intodocker:masterfrom
tonistiigi:init-fixes
Jul 24, 2024
Merged

Improvements based on inittrace#2601
tonistiigi merged 4 commits intodocker:masterfrom
tonistiigi:init-fixes

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

Selection of improvements for best practices and avoiding big memory allocations in init stage in places where it doesn't degrade readability. For benchmarks this doesn't make a giant difference overall as bigger issues are in some of the dependencies, but need to start somewhere. This is mostly preparation for some other updates and for defining standards for future changes. All regexp.Compile issues were skipped for now but the detection logic is in https://gist.github.com/tonistiigi/1d58b4c2de41d194f35ac2c9f029f586 . Validations like this should be eventually integrated into CI.

@tonistiigi tonistiigi merged commit 3d542f3 into docker:master Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants