build: fix stdin handling when building with controller#2394
Merged
tonistiigi merged 1 commit intodocker:masterfrom Apr 9, 2024
Merged
build: fix stdin handling when building with controller#2394tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi merged 1 commit intodocker:masterfrom
Conversation
crazy-max
force-pushed
the
fix-stdin-controller
branch
from
8492eec to
02c4983
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
fix-stdin-controller
branch
from
02c4983 to
ffff87b
Compare
tonistiigi
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2368
When building in experimental mode we are using the controller which handles io forwarding operations, such as copying data from a reader to a writer and therefore locks stdin from being read in
buildx/build/opt.go
Line 384 in 5c29e6e
To fix this we can skip forwarding if invoke is not used as it seems to be handled only for this case. We also have a clear condition making it not possible to use a Dockerfile or context from stdin if invoke is used:
buildx/commands/build.go
Lines 397 to 400 in 0a3e5e5
This should mitigate this issue but might need a deeper look as follow-up