driver(docker-container): fix incorrect path when writing certs#1831
Merged
crazy-max merged 1 commit intodocker:masterfrom May 26, 2023
Merged
driver(docker-container): fix incorrect path when writing certs#1831crazy-max merged 1 commit intodocker:masterfrom
crazy-max merged 1 commit intodocker:masterfrom
Conversation
Replace invalid characters in the name of the base directory of certificates using the name of the registry which can contain for example a colon when the port is specified. Signed-off-by: CrazyMax <[email protected]>
thaJeztah
reviewed
May 23, 2023
| continue | ||
| } | ||
| pfx := path.Join("certs", regName) | ||
| pfx := path.Join("certs", reInvalidCertsDir.ReplaceAllString(regName, "_")) |
Member
There was a problem hiding this comment.
IIRC, the engine uses the (awkward) : as-is for Linux, but on Windows it strips it; https://github.com/moby/moby/blob/6e98a7f2c9184d4e91df8abf06e2245a0cd77c58/registry/config_windows.go#L12-L20
jedevc
approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1827
Replace invalid characters in the name of the base directory of certificates using the name of the registry which can contain for example a colon when the port is specified.