Skip to content

[v0.10] vendor: update buildkit to v0.11@348e79dfed17#1815

Merged
jedevc merged 1 commit intodocker:v0.10from
jedevc:v0.10-vendor-buildkit
May 22, 2023
Merged

[v0.10] vendor: update buildkit to v0.11@348e79dfed17#1815
jedevc merged 1 commit intodocker:v0.10from
jedevc:v0.10-vendor-buildkit

Conversation

@jedevc
Copy link
Copy Markdown
Collaborator

@jedevc jedevc commented May 19, 2023

Significant changes:

We may want to wait to do a BuildKit v0.11.7 release if we want to don't want to vendor the pseudo-version.

@tonistiigi
Copy link
Copy Markdown
Member

Unless there are any other bugfixes here, I would rather just pick the patches with a replace rule for a quick release. We are about to release v0.11 in a couple of days anyway and this will be EOL. The other updates in buildkit seem harmless, but the containerd has actual logic changes.

@jedevc
Copy link
Copy Markdown
Collaborator Author

jedevc commented May 19, 2023

So a separate branch in buildkit? Any preferences on name?

@tonistiigi
Copy link
Copy Markdown
Member

fix-session-close-race, can be from your fork.

@jedevc
Copy link
Copy Markdown
Collaborator Author

jedevc commented May 22, 2023

Going through the containerd changes, I actually think there's only a single logic change that should affect us: https://github.com/jedevc/buildx/blob/v0.10-vendor-buildkit/vendor/github.com/containerd/ttrpc/server.go. The others are doc comments, formatting, etc. OCI image-spec just adds a few new struct fields that we don't use really.

Aside from that, we just pull in our own buildkit changes, which I'm tempted to trust 🎉 Nothing there looks particularly high risk.

I think we should just pull all the changes in.

@jedevc jedevc marked this pull request as ready for review May 22, 2023 16:15
@jedevc jedevc merged commit 86bdced into docker:v0.10 May 22, 2023
@jedevc jedevc deleted the v0.10-vendor-buildkit branch May 22, 2023 16:28
@crazy-max crazy-max changed the title vendor: update buildkit to v0.11@348e79dfed17 [v0.10] vendor: update buildkit to v0.11@348e79dfed17 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants