Support new compose features in bake#1784
Merged
jedevc merged 2 commits intodocker:masterfrom May 11, 2023
Merged
Conversation
compose-go v1.13.0 supports the new dockerfile_inline to allow including a dockerfile inline in the compose definition, so we should map this to bake's dockerfile-inline property. Signed-off-by: Justin Chadwell <[email protected]>
compose-go v1.13.0 supports the new additional_contexts to allow passing additional build context during build, so we should map this to bake's contexts property. Signed-off-by: Justin Chadwell <[email protected]>
crazy-max
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⬆️ Follow-up to #1753 (cc @nicksieger)
compose-go v1.13.0 supports the new
dockerfile_inlineandadditional_contextsproperties, so we should translate them to the relevant bake construct.Will probably need an update in https://docs.docker.com/build/bake/compose-file/ after merging.