kubernetes driver: add support for proxy-url#1780
Merged
crazy-max merged 1 commit intodocker:masterfrom May 11, 2023
Merged
Conversation
IamShobe
force-pushed
the
elranshefer/add-support-for-proxy-url
branch
from
e5e7436 to
6a1af0b
Compare
Collaborator
|
Looks good, but please squash commits |
Signed-off-by: Elran Shefer <[email protected]>
IamShobe
force-pushed
the
elranshefer/add-support-for-proxy-url
branch
from
6a1af0b to
29b427c
Compare
Author
|
Done :) |
AkihiroSuda
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there :),
Sorry about the previous PR, I opened it prematurely before finalizing all tests, and preparing a proper PR 🙏.
Hopefully, I'm properly following your contribution guidelines, and if I need to change anything please LMK.
This PR attempts to add support in
kuberenetes driverforproxy-urlconfig in theKUBECONFIGfile -official docs here.
The PR initializes the k8s client config created in
KubernetesConfigreceiver method with the rightproxy-urlparameter.As a workaround, we were using
HTTPS_PROXYenv var, but that forces every request thatbuildxsends to use the same proxy as well.This feature, allows only the traffic that goes to the k8s cluster (kubeapi) - to be routed via the proxy.
Signed-off-by: Elran Shefer [email protected]