docker: fix connection leak on features check#1776
Merged
jedevc merged 1 commit intodocker:masterfrom May 9, 2023
Merged
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
approved these changes
May 8, 2023
jedevc
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client created from the features request is left open, meaning a connection leak will happen if the docker driver is used as a library and a new instance of driver is created.
It would be better if a new client would not be created at all for this check, but the same client would be reused. I will follow-up with combining these but wanted to fix the issue first.