container-driver: avoid hanging on container panic#1772
Merged
tonistiigi merged 1 commit intodocker:masterfrom May 9, 2023
Merged
container-driver: avoid hanging on container panic#1772tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
commented
May 4, 2023
| var counter int64 | ||
| opts = append(opts, client.WithContextDialer(func(context.Context, string) (net.Conn, error) { | ||
| if atomic.AddInt64(&counter, 1) > 1 { | ||
| return nil, net.ErrClosed |
Member
Author
There was a problem hiding this comment.
This is just for cleaner error handling. It would work without it as well.
jedevc
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When buildkit container dies with sigkill while the progress is streaming, it could have left the progress hanging.