Skip to content

cli: add shell completion#1727

Merged
crazy-max merged 4 commits intodocker:masterfrom
crazy-max:cmd-completion
May 9, 2023
Merged

cli: add shell completion#1727
crazy-max merged 4 commits intodocker:masterfrom
crazy-max:cmd-completion

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Apr 9, 2023 •
edited
Loading

closes #1674
partially solves #1072

Add completion to:

  • List builder names for --builder persistent flag and as arg for some cmds
  • Folders (context) for build command
  • List bake targets
$ docker __completeNoDesc buildx --builder ""
builder
builder2
buildkit0106
buildkit093
remote-builder
default
desktop-linux
docker201016
docker2300
docker2400
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

$ docker __completeNoDesc buildx --builder "do"
docker201016
docker2300
docker2400
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

For bake, can be tested within this repo:

$ docker __completeNoDesc buildx ""
bake
build
create
du
help
imagetools
inspect
ls
prune
rm
stop
use
version
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

$ docker __completeNoDesc buildx bake ""
default
validate
meta-helper
_common
lint
validate-vendor
validate-docs
validate-authors
validate-generated-files
update-vendor
update-docs
update-authors
update-generated-files
mod-outdated
test
binaries
binaries-cross
release
image
image-cross
image-local
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

$ docker __completeNoDesc buildx bake "v"
validate
validate-vendor
validate-docs
validate-authors
validate-generated-files
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

thaJeztah
thaJeztah reviewed Apr 9, 2023
View reviewed changes
Comment thread util/cobrautil/completion.go Outdated
@crazy-max crazy-max marked this pull request as ready for review April 11, 2023 07:34
@crazy-max crazy-max requested review from jedevc and tonistiigi April 11, 2023 07:35
jedevc
jedevc reviewed Apr 11, 2023
View reviewed changes
Comment thread util/cobrautil/completion.go
@jedevc jedevc added this to the v0.11.0 milestone Apr 11, 2023
jedevc
jedevc reviewed Apr 25, 2023
View reviewed changes
Comment thread commands/build.go
@crazy-max crazy-max merged commit 621b07c into docker:master May 9, 2023
@crazy-max crazy-max deleted the cmd-completion branch May 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@jedevc jedevc jedevc approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees

No one assigned

Labels

area/cli

Projects

None yet

Milestone

v0.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@crazy-max @thaJeztah @jedevc