build: fixup resolvePaths for remote context path#1701
Merged
jedevc merged 1 commit intodocker:masterfrom Mar 29, 2023
Merged
Conversation
crazy-max
approved these changes
Mar 28, 2023
ktock
approved these changes
Mar 29, 2023
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
fixup-resolve-paths-context-path
branch
from
f7b22ee to
b5c6b3f
Compare
ktock
approved these changes
Mar 29, 2023
crazy-max
approved these changes
Mar 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #1581 - the context path can be a URL, which would not work when using the controller path.
This fixes the detection to not resolve the path to the current working directory if it's a URL, similar to the logic for named contexts.