build: print instance being used#1177
Conversation
d419196 to
afd5d17
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jedevc
left a comment
There was a problem hiding this comment.
LGTM 🎉
I'd prefer to replace the progress.Wrap call with a oneOffProgress function just so we don't forget to grep it out when the buildkit PR merges, but not a blocker 👍
|
I'm not so sure about this. This is not really a progress item, a step that runs as part of the build on a specific time/duration. Is it more like a debug log line? Maybe if we could fit the instance name on the first line? For |
Yes that's it.
Sounds good, I will take a look |
aa9454f to
7ea76fb
Compare
7ea76fb to
db919a5
Compare
172a9df to
e6cea70
Compare
jedevc
left a comment
There was a problem hiding this comment.
LGTM - just a note, this doesn't work with the remote controller, which has it's own progress setup.
However, that's fine if we can open a tracking issue after this merges, I think some more general refactoring of how we do progress is necessary to get a patch that makes more sense for this.
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
e6cea70 to
598f1f0
Compare
needs moby/buildkit#3378Display current builder being used when building. Can help users who need to know the type of builder in use during their build but also for log reports:
Signed-off-by: CrazyMax [email protected]