-
Notifications
You must be signed in to change notification settings - Fork 619
Closed
Labels
Milestone
Description
relates to:
- Unable build docker-compose file with advanced network configuration #612
- bake does not support compose profiles #718
- Additional property name is not allowed #1106
- Bake does not allow or use tags from docker-compose.yml #1187
- buildx bake file doesn't support new ulimit directives #2241
- cgroup property is not allowed when using bake command with docker compose as input #2548
When new properties are added to the compose spec, Bake might fail to build them as the validation is not yet aware of them unless the compose-go dependency is updated and a new release of Buildx made. We should just validate the build property that is the only part we are using with bake to prevent such issues.
@ndeloof @glours Would it be possible to have an option in the loader to just validate specific properties?:
Lines 44 to 52 in 758ea75
| }, func(options *loader.Options) { | |
| projectName := "bake" | |
| if v, ok := envs[consts.ComposeProjectName]; ok && v != "" { | |
| projectName = v | |
| } | |
| options.SetProjectName(projectName, false) | |
| options.SkipNormalization = true | |
| options.Profiles = []string{"*"} | |
| }) |
Maybe smth like ValidateBuildOnly or SkipUnknown?
Reactions are currently unavailable