Skip to content

sigstore: default blob attestation verification to SLSA provenance v1#1060

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:sigstore-fix-verified-blob
Apr 8, 2026
Merged

sigstore: default blob attestation verification to SLSA provenance v1#1060
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:sigstore-fix-verified-blob

Conversation

@crazy-max
Copy link
Copy Markdown
Member

relates to https://github.com/docker/github-builder/actions/runs/24074179428/job/70218412185#step:14:65

  Verifying signed artifact /tmp/buildx-output/linux_amd64/hello.txt
  /home/runner/work/_temp/docker-actions-toolkit-NBoV3A/cosign-bin/cosign verify-blob-attestation --new-bundle-format --certificate-oidc-issuer https://token.actions.githubusercontent.com --certificate-identity-regexp ^https://github.com/docker/github-builder/.github/workflows/bake.yml.*$ --bundle /tmp/buildx-output/linux_amd64/provenance.sigstore.json /tmp/buildx-output/linux_amd64/hello.txt
  Error: invalid predicate type, expected custom got https://slsa.dev/provenance/v1
  error during command execution: invalid predicate type, expected custom got https://slsa.dev/provenance/v1

Cosign used to silently ignore the missing predicate type in this path, but 3.0.6 started enforcing it ( see sigstore/cosign#4801) and fails with:

invalid predicate type, expected custom got https://slsa.dev/provenance/v1

Our signed provenance blobs are SLSA v1 attestations, so defaulting verification to slsaprovenance1 fixes the regression without forcing every caller to pass an obvious constant.

@crazy-max crazy-max requested a review from tonistiigi April 7, 2026 14:49
@crazy-max crazy-max marked this pull request as ready for review April 7, 2026 14:49
@crazy-max crazy-max merged commit 638fb92 into docker:main Apr 8, 2026
333 of 335 checks passed
@crazy-max crazy-max deleted the sigstore-fix-verified-blob branch April 8, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants