Merge pull request #115 from crazy-max/input-comment-opt

crazy-max · web-flow · commit 495c96b050e0 · 2023-06-13T10:31:11.000+02:00
util: comment opt for getInputList
diff --git a/__tests__/util.test.ts b/__tests__/util.test.ts
@@ -73,6 +73,18 @@ describe('getInputList', () => {
     expect(res).toEqual(['user/app:cache', 'type=local,src=path/to/dir']);
   });
 
+  it('multiline and ignoring comment correctly', async () => {
+    setInput('labels', 'foo=bar\nbar=qux#baz');
+    const res = Util.getInputList('labels');
+    expect(res).toEqual(['foo=bar', 'bar=qux#baz']);
+  });
+
+  it('multiline with comment', async () => {
+    setInput('labels', 'foo=bar\nbar=qux#baz');
+    const res = Util.getInputList('labels', {comment: '#'});
+    expect(res).toEqual(['foo=bar', 'bar=qux']);
+  });
+
   it('different new lines and ignoring comma correctly', async () => {
     setInput('cache-from', 'user/app:cache\r\ntype=local,src=path/to/dir');
     const res = Util.getInputList('cache-from', {ignoreComma: true});
diff --git a/src/util.ts b/src/util.ts
@@ -21,6 +21,7 @@ import {parse} from 'csv-parse/sync';
 
 export interface InputListOpts {
   ignoreComma?: boolean;
+  comment?: string;
   quote?: string | boolean | Buffer | null;
 }
 
@@ -36,7 +37,7 @@ export class Util {
     const records = parse(items, {
       columns: false,
       relaxQuotes: true,
-      comment: '#',
+      comment: opts?.comment,
       relaxColumnCount: true,
       skipEmptyLines: true,
       quote: opts?.quote
