Skip to content

fix(app): align Marketplace with Settings V2 styles - #20

Merged
dobord merged 5 commits into
marketplacefrom
fix/marketplace-settings-v2-style
Jul 30, 2026
Merged

dobord merged 5 commits into
marketplacefrom
fix/marketplace-settings-v2-style

Conversation

@dobord

@dobord dobord commented Jul 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes the Marketplace visual mismatch inside the Settings V2 dialog.

  • replaces raw Marketplace text inputs with TextInputV2;
  • replaces native selects with SelectV2;
  • replaces ad-hoc action buttons with ButtonV2;
  • switches package/source toggles to the V2 Switch;
  • uses Settings V2 background, border, text, hover, selected, elevation, and focus tokens;
  • aligns Marketplace header/content spacing and panel surfaces with Providers and Models;
  • removes the orange focus outline from both source text fields by using the same --v2-border-border-focus blue focus token as the Models search field;
  • preserves Marketplace behavior, revision handling, source management, and accessibility labels.

Root cause

Marketplace was mounted inside Settings V2 while still using raw HTML form controls and the legacy surface/color token set. Consequently its URL field, display-name field, select, buttons, panels, and selected states did not follow the shared Settings V2 visual system.

The orange outline was a styling inconsistency. It was independent of URL validation and independent of the entered value.

Implementation

The panel now uses the shared V2 primitives:

TextInputV2
SelectV2
ButtonV2
Switch V2

A scoped marketplace-dialog.css maps Marketplace surfaces and residual typography to the V2 theme tokens without changing Marketplace data flow or API behavior.

Validation

The clean product-code head passed the dedicated validation pipeline:

  • Prettier formatting;
  • packages/ui typecheck;
  • packages/app typecheck;
  • complete app unit suite;
  • git diff --check.

The repository test workflow has additionally passed:

  • Linux unit suite;
  • Linux app E2E;
  • Windows app E2E;
  • HttpApi coverage;
  • HttpApi authentication;
  • HttpApi Effect/runtime.

The hosted Windows unit job was still running when this description was last updated.

Bug tracking

GitHub Issues are disabled for dobord/opencode, so a standalone issue cannot be opened in this repository. The bug is tracked by this PR with the bug label and by a tracking comment on feature PR #1.

@github-actions

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@dobord dobord added the bug Something isn't working label Jul 30, 2026 — with ChatGPT Codex Connector
@dobord
dobord marked this pull request as ready for review July 30, 2026 11:42
@dobord
dobord merged commit 57ec76c into marketplace Jul 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant