Repository navigation
fix(app): align Marketplace with Settings V2 styles - #20
Merged
Merged
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Marketplace visual mismatch inside the Settings V2 dialog.
TextInputV2;SelectV2;ButtonV2;Switch;--v2-border-border-focusblue focus token as the Models search field;Root cause
Marketplace was mounted inside Settings V2 while still using raw HTML form controls and the legacy surface/color token set. Consequently its URL field, display-name field, select, buttons, panels, and selected states did not follow the shared Settings V2 visual system.
The orange outline was a styling inconsistency. It was independent of URL validation and independent of the entered value.
Implementation
The panel now uses the shared V2 primitives:
A scoped
marketplace-dialog.cssmaps Marketplace surfaces and residual typography to the V2 theme tokens without changing Marketplace data flow or API behavior.Validation
The clean product-code head passed the dedicated validation pipeline:
packages/uitypecheck;packages/apptypecheck;git diff --check.The repository test workflow has additionally passed:
The hosted Windows unit job was still running when this description was last updated.
Bug tracking
GitHub Issues are disabled for
dobord/opencode, so a standalone issue cannot be opened in this repository. The bug is tracked by this PR with thebuglabel and by a tracking comment on feature PR #1.