Improved css reset for deafault.css#7371
Merged
Merged
Conversation
"modern-normalize" was already in the dev-dependencies for the clientside project but was unused. Instead a manual css reset was in place which was too strong and made the default `em` `<i>` `<strong>` `<b>` have wrong defaults that made them useless. I believe this was temporary and the intention was to use modern-normalize in the first place and it was gorgotten. This PR fixes that. The above elements now look fine and I went over the default theme and the DNN UI parts and it appers to not have affected them. Closes dnnsoftware#7352
Contributor
|
Thanks :-) |
bdukes
approved these changes
Jul 14, 2026
bdukes
enabled auto-merge
July 14, 2026 19:09
mitchelsellers
approved these changes
Jul 14, 2026
Contributor
|
I accidentally merged this, but we're intending to include this in 10.4.0 instead. I've pushed a revert commit |
Contributor
|
Moved to #7372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"modern-normalize" was already in the dev-dependencies for the clientside project but was unused. Instead a manual css reset was in place which was too strong and made the default
em<i><strong><b>have wrong defaults that made them useless.I believe this was temporary and the intention was to use modern-normalize in the first place and it was gorgotten.
This PR fixes that. The above elements now look fine and I went over the default theme and the DNN UI parts and it appers to not have affected them.
Closes #7352