FIX: Ckeditor padding + heading sizes#7368
Conversation
Timo-Breumelhof
changed the title
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
This technically affects more than the problem in question and technically is a bit of a change for all usages of the ui/ux pattern. However I do believe it is the right thing to do as those headers were incorrectly huge everywhere. So my vote goes to just go ahead with this change.
|
@Timo-Breumelhof this is marked as draft, is that on purpose because you are still working on it w you want to mark this ready for review? |
|
@valadas yes, I still need to check something but ran out of time, I'll finish this one next week |
|
@valadas Not sure why Github still shows https://github.com/dnnsoftware/Dnn.Platform/pull/7368/changes#diff-0f32dffa00fbb4b53f979f3524fd4f69451050cda001ae563ed49e27e702da7b as a changed file? |
eb35273 to
6484f4d
Compare
|
I've noticed the diffing in GitHub getting things wrong recently, especially with merges. I rebased your branch on |
Ok thanks @bdukes :-) |
4 participants
2 Commits.
A. Very simple add some padding to the CkEditor screen
B. For the heading sizes, ended up being a bit more complex.
Summary
About the Heading size issue.
I noticed this:
A difference in heading sizes.
dnnFormSectionHead can contain a link or a span
The second one contains a span the others a link.
Span size:
Dnn.Platform/DNN Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/ui/_forms.scss
Line 249 in 1e3b3c8
Anchor size:
Dnn.Platform/DNN Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/default.scss
Line 20 in 1e3b3c8
This is why they are different.
If you look at the interface, the heading a really large and IMO the size of the span is actually better than the ones containing a link. In edit users you get this:
Which looks weird IMO
So I moved what was in forms.scss into default.scss (not the best place but at least in one place)
And made them both the same size in rem.
There's a lot more one could changes here, but for now this at least fixes the issue of the header sizes.
FYI,
Manage users after this change:
Ckeditor manager
fixes #7367