FIX: default.css > Conflicting duplicate rule padding blocks for the same selectors > forms.scss#7358
Merged
donker merged 1 commit intoJul 4, 2026
Conversation
donker
approved these changes
Jul 3, 2026
donker
enabled auto-merge
July 3, 2026 15:52
valadas
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor issue, no issue created
Summary
Conflicting duplicate rule blocks for the same selectors
File: ui/_forms.scss:169-177 and 189-195
First block (line 177):
padding: 0.5625rem;
Second block, four lines later, targeting an overlapping selector list
(.dnnFormItem button, input[type=button/reset/submit], .dnnPrimaryAction,
.dnnSecondaryAction, .dnnTertiaryAction) (line 195):
padding: 0.375rem;
The second declaration silently wins for the shared selectors. Having two
separate rule blocks assign different values to the same property on
overlapping selectors makes it unclear which value is "the" intended
padding.
Solution: the end result (buttons/actions at 0.375rem,