FIX: default.css > Default css/rgb var not dynamic#7356
Merged
donker merged 2 commits intoJul 4, 2026
Conversation
Timo-Breumelhof
changed the title
Contributor
|
This appears to be a better and more complete fix for #7355 am I correct? |
Contributor
Author
|
@mitchelsellers hmm I think I accidentally have one commit in two PRs, sorry about that |
Contributor
Author
|
@mitchelsellers I guess as this is all minor the easiest is to just drop the other one? |
donker
approved these changes
Jul 3, 2026
donker
enabled auto-merge
July 3, 2026 15:50
valadas
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor issue, not issue created
Summary
Two of three color channels hardcoded in an otherwise-variable rgba()
File: modules/_tables.scss:56-61 (same rule as 1.3)
background: rgba(
var(--dnn-color-info-r, 2),
139,
255,
0.15);
The red channel comes from --dnn-color-info-r, but green/blue are hardcoded
literals (139, 255) instead of --dnn-color-info-g/-b. Even once 1.3 is
fixed, a theme changing --dnn-color-info can only shift one of the three
channels of this hover tint.
Solution: see 1.3 above - use var(--dnn-color-info-g, 139) and
var(--dnn-color-info-b, 255) so all three channels track the theme's
--dnn-color-info the same way -r already does.