Unable to create social group as non-admin#7345
Merged
Merged
Conversation
mitchelsellers
approved these changes
Jun 30, 2026
Group creation fails when a non-admin supplies a group image due to the permissions check saving the image.
Having permission to create a group is enough of a signal, and checking membership in the group doesn't work when groups require approval
Also apply changes from Create to GroupEdit
valadas
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When creating a social group and supplying an image, the creation fails (partially succeeds in a non-recoverable way) because uploading the group image runs into a permissions failure. The solution ended up being to not check the permissions, because having the ability to create the group already confirms the ability to upload to that group's folder (but the actual permission grant to that folder has to happen later in some scenarios).